Misc Python update / signal / child-workflow features #361
Conversation
|
Added all my non-typescript outstanding changes to this PR, so it now contains
|
dandavison
changed the title
dandavison
changed the title
| CHILD_WORKFLOW_INPUT = "child-input" | ||
| CHILD_WORKFLOW_INITIAL_STATE = "1" | ||
| SIGNAL_ARG = "2" |
There was a problem hiding this comment.
Don't have to change, but for me extracting constants out in these tiny tests doesn't have much value
There was a problem hiding this comment.
Agree I had too many constants. I think I still like one or two of them where they are repeated several times and critical to test logic.
| @workflow.defn | ||
| class ChildWorkflow: | ||
| def __init__(self) -> None: | ||
| self._state = CHILD_WORKFLOW_INITIAL_STATE |
There was a problem hiding this comment.
| self._state = CHILD_WORKFLOW_INITIAL_STATE | |
| self._state: Optional[str] = None |
Instead of constants, but this is pedantic, don't have to change
There was a problem hiding this comment.
Thanks, agree that's a cleaner form for the initial state. Taken.
There was a problem hiding this comment.
May want to apply to other features in this PR
|
Thanks for reviewing. I've converted this to draft as a marker that it can't be merged yet. |
dandavison
force-pushed
the
non-update-features
branch
from
5087cbb
to
918ab3d
Compare
dandavison
force-pushed
the
non-update-features
branch
2 times, most recently
from
a5998b4
to
3ab582e
Compare
dandavison
changed the title
No description provided.